ADA Depot Too - A Forum To Support Users of ADA Amplification Gear

Let's Get Technical => All PREAMP Tech Tips & Support => Topic started by: GuitarBuilder on December 30, 2013, 11:09:57 AM

Title: ADA MP-1 Digital Modification
Post by: GuitarBuilder on December 30, 2013, 11:09:57 AM
I just rediscovered this project; it looks like the author has slowed down a little, but it's still pretty interesting.

http://mp1.damicos.net/ (http://mp1.damicos.net/)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on December 31, 2013, 02:25:40 PM
Great he is still working on this.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on January 01, 2014, 10:56:36 PM
Cool project, thanks for the link  :wave:
Title: Re: ADA MP-1 Digital Modification
Post by: GuitarBuilder on June 07, 2016, 02:30:25 PM
Necropost warning......

I just checked on Mike D'Amico's site and it would appear he stopped working on this project in December 2014.  Bummer!  I was looking forward to a great result.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 08, 2016, 04:41:48 AM
Yeah I was hoping good things would come of it also.  Oh well, maybe he'll get back to it at some stage. :dunno:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 08, 2016, 05:40:29 AM
Let's hope so  :thumb-up:
Title: Re: ADA MP-1 Digital Modification
Post by: El Chiguete on June 09, 2016, 10:44:37 AM
Maybe someone can contact him and invite him to this forum?
Title: Re: ADA MP-1 Digital Modification
Post by: Harley Hexxe on June 09, 2016, 01:14:52 PM
I think he's already a member

Harley 8)
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on June 10, 2016, 09:35:31 AM
He is - or was on the old forum - a member; I don't remember his logon name, but can check the few old files from the old forum I do have outside of the crashed server drive (oh dear, the project of getting the stuff off that drive..)

Yeah, interesting project. I'd find it easier, though, reverse engineering the original code for adding things like CC.
Easy, well... it's one thing getting the code disassembled, but a much higher workload understanding every single line of machine generated assembly code and  adding comments to be able to work on it.. ;)
Title: Re: ADA MP-1 Digital Modification
Post by: GuitarBuilder on June 10, 2016, 12:49:13 PM
He is - or was on the old forum - a member; I don't remember his logon name, but can check the few old files from the old forum I do have outside of the crashed server drive (oh dear, the project of getting the stuff off that drive..)

Yeah, interesting project. I'd find it easier, though, reverse engineering the original code for adding things like CC.
Easy, well... it's one thing getting the code disassembled, but a much higher workload understanding every single line of machine generated assembly code and  adding comments to be able to work on it.. ;)

His logon name was mcss
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 10, 2016, 01:18:00 PM
He's a member here but posted only once and was last online 477 days ago.
Title: Re: ADA MP-1 Digital Modification
Post by: Harley Hexxe on June 10, 2016, 03:03:03 PM
He's a member here but posted only once and was last online 477 days ago.

   Isn't it funny how several of the old Forum members who used to be on every day, showed up here for a little while, then just seemed to lose interest?

     Harley 8)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 10, 2016, 03:30:00 PM
Yes it is,which is to bad.
Title: Re: ADA MP-1 Digital Modification
Post by: Peter H. Boer on June 12, 2016, 01:22:24 AM
Well, for some life gets in the way.

I still would like to see more bassplayers here, but that was a small bunch on the old forum too  :'(
Title: Re: ADA MP-1 Digital Modification
Post by: Harley Hexxe on June 12, 2016, 07:55:11 AM
Well, for some life gets in the way.

I still would like to see more bassplayers here, but that was a small bunch on the old forum too  :'(

   Yes Peter, life does get in the way at times, just like with myself at the moment. With the extra work, and the social engagements I have going on at this point in time, I can't get to my rack to work on it and finish it. Still, the equipment isn't the only reason I come to this Forum. It's the people I've come to know here, who are some of the best personalities in the world, that keeps me coming back.

    Harley 8)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 12, 2016, 02:35:34 PM
+1 Harley  :thumb-up:
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 12, 2016, 09:40:02 PM
+ 1 Harley  :thumb-up: :wave: . One thing I've noticed is we all seem to have in common is serious GAS Lo  >:D .
Another project that fizzled was a programming interface for the MP2, it had some "legs" on the original board but then  :dunno: .  I remember having a library program years ago (Win98 days) that interfaced with a bunch of kit but also let you customise a module for other gear. I was too busy recording back then and never got around to using it.

I wonder if any members have some sysex programing expertise ?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 13, 2016, 02:03:41 AM
Ah yes I remember that, too bad it never got finished. Would have been great to have a PC interface for the MP-2.

There was a program that could do a lot of the effect units and synth and stuff, I think it was called midi quest.So I did a search for it and it still exists. But to bad, still no ADA support.

https://www.squest.com/Products/MidiQuest11/Instruments.html

Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 14, 2016, 06:27:05 AM
The pro version says you can create new editors, they also say you can request a unit to be added, probably just need to give them the sysex commands list.
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on June 14, 2016, 06:31:12 AM
Dante at some point used and external MIDI thingy with rotating encoders and buttons to program [parts of] the MP-2; IIRC, the gain block and EQ, maybe more..
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on June 14, 2016, 08:47:03 AM
I did?   :lol:

I think I got a midi controller to run some CC commands in my MP-2 back in the day. I haven't hooked up that controller in a long time - it's a 64-key keyboard with some faders and volume pots, nothing fancy.

There has to be a sysex option out there that we can customize to work with an MP-2. If one of the big brained individuals on this forum comes up with a way, I may be able to hack a decent interface together  O0
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 14, 2016, 09:48:14 AM
I guess the problem here is that we don't have any sysex info about the mp-2?
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 15, 2016, 05:22:46 AM
We need to get the MP2 sysex implementation, maybe Monty can help ??  I assume it uses the standard calls plus some ADA specific extensions ? There's a bit at the back of the MP1 manual, I suspect some of it will be the same.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 15, 2016, 09:57:12 AM
I just went through all the ADA paperwork I got from Jur and I found some good information. I'll scan it and put it here.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 15, 2016, 10:04:15 AM
Okay here it is.Had a quick look at it and it seems to be for the MP-1,MP-2,MB-1 V1.xx,MB-1 V2.xx,Quadtube 150 and the Tritube 75.
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on June 15, 2016, 10:16:16 AM
That looks pretty promising! Now, what do we do with it?  :dunno:

Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 15, 2016, 10:21:31 AM
Maybe make a PC based editor ??
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 16, 2016, 07:42:25 AM
There seems to be 2 ways to go.  Easiest is to use a library program (like the one MJMP posted the link for) which lets you define your own unit (sysex commands) as one of its modules.  So the interface work is done (user interface and midi comms) albeit with their look and feel/widgets (eg sliders/pots/buttons etc). Though this option seems to come with the pay for it pro versions ??

Or we write a PC program (in Visual Basic or Python or C++ etc), where we'd have to write (or purloin (which may decide the prog. language we use)) all the various widgets and user interface and comms (basically write a library program or part thereof).

While there's good information in the ADA midi sysex pdf, I'm not sure it's all there (well maybe for the MP1), but from my quick researching it seems sysex isn't too hard or complicated, just have to get your head around it.  I spotted a sysex primer youtube clip (yet to watch) in a google search which is a good start (regardless of which direction we choose).
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on June 16, 2016, 10:09:09 AM
Easiest is to use a library program (like the one MJMP posted the link for) which lets you define your own unit (sysex commands) as one of its modules.  So the interface work is done (user interface and midi comms) albeit with their look and feel/widgets (eg sliders/pots/buttons etc). Though this option seems to come with the pay for it pro versions ??

That does sound easiest, if it works. I should be able to make different UI graphics to look like an ADA. Worth a shot
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 16, 2016, 01:38:16 PM
Okay and maybe if that works we could also make a handheld version of it in a small box ? (with an arduino or something)

And yes there seems to be missing a few things, like appendix B and C.

I also found some sysex stuf for the MQ-1 but that's more or less the same as the MP-1.

Could be a fun project to make, although this is more your expertise. But a handheld that's something I could make. And I guess we'll make this an open source project ?? So anybody can help if they want.
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on June 16, 2016, 02:08:43 PM
If it's online, you can use your phone. That's a handheld supercomputer ;)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 16, 2016, 02:41:12 PM
 :lol: BUT you also will need a interface unless your MP-2 has been modified with Bluetooth or WiFi  :facepalm:
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 17, 2016, 09:20:16 AM
It's definitely a fun project and I suspect we can probably nut out some of the missing sysex bits (no pun intended) with a bit of trial and error.  We have to watch out for scope creep as that will kill it but we can start simple with other ideas in mind so they can be added later?
But this is going down the "we'll" write/build it path, in which case it makes sense to make it browser based so it runs on most things.
There is allot of work in this approach BTW.

Adapting a library program module (where they let you) while being much easier and faster may lock it into one library package.  But there may well be some good free open source library programs we could use.  Lets all have a dig around for whats out there.

Open source is the go I recon too MJMP.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 17, 2016, 09:44:02 AM
Ok sounds good!!
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on June 17, 2016, 02:26:15 PM
:lol: BUT you also will need a interface unless your MP-2 has been modified with Bluetooth or WiFi  :facepalm:

How about a midi interface for the phone? That should do it. I have one for my iPod (the iRig Midi)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 17, 2016, 03:18:28 PM
https://www.engadget.com/2015/07/21/zivix-puc-plus-midi-bluetooth/
Title: Re: ADA MP-1 Digital Modification
Post by: tomy on June 17, 2016, 03:46:41 PM
waow ! awesome... but you need an app to control your old school ada gear ?
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on June 17, 2016, 04:26:14 PM
https://www.engadget.com/2015/07/21/zivix-puc-plus-midi-bluetooth/

That is VERY interesting!

Tomy: Yes. Have you ever tried to edit 10 banks of patches in your MP-2? It is a lot of button mashing, it would be much easier to simply copy/paste some of those settings in a spreadsheet or something like that.

I don't know how the rest of you heathens set up your patches, but I have a bank of 10 patches for each guitar. So, if one setting gets changed in one bank, it's probably getting changed 10-12 times for the other guitars.
Title: Re: ADA MP-1 Digital Modification
Post by: tomy on June 17, 2016, 04:35:54 PM
following your idea when i rebuilt my gear, I did  the same on MP2 and now on mb1 too, I think it's a good way to manage preset
-1 guitar = 1 bank  :thumb-up:

But having an app for editing really help, I've tried the one with MP1... and it is way easier !
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 18, 2016, 04:31:58 AM
This also looks nice

http://www.miupanel.com/Overview

You can hook it up to an arduino or any other controller. So we could write an app for it and use an arduino (since these are very cheap to get) as an interface.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 18, 2016, 04:32:56 AM
I just though of a band-aid type intermediate solution.  When you do a program dump/backup to PC (using one of the programs that let you do this), it's stored in a file pretty much as plain text (from the ones I've seen). If you open the file in a text editor (eg notepad), you can edit the patches, save as a copy. then reload them (unless there are any check sums involved). So Dante, your case, you could make the change to one bank then save/edit (all the banks) /load.

So the Puc will provide an interface (though ADA pre's don't support the bi-directional midi they talk about) we need an in and an out. Currently without using midi out the program won't know what the current settings are ??  Well that's my current understanding  :dunno:
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 18, 2016, 04:51:43 AM
Hey MJMP, the uPanel stuff looks good, would solve all the widget issues (at least for smart phone use).  Not sure how you'd access it from PC (Browser+wiFi ?)  Also we still have to connect to midi in/outs on the ADA.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 18, 2016, 05:43:57 AM
I think it's best we make a PC editor first, because we have to do some figuring out how it all works. Most soundcards have a midi connection so we can use that to interface with the mp-x .And if that works we can start on a hardware interface for a phone or tablet? It's easy to use midi in and out on a arduino.

From what i can read if you change a parameter you also have to change the checksum?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 18, 2016, 11:55:15 AM
I think it would be easier, if we write a whole program for ourselves, so we dont need to figure out, how the libraries are built up.

Since all values ar "just" HEX , it should be quite easy to transfer the HEX Codes.
IIRC, there are usable MIDI-Libraries for Languages like C/C# and so on.
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on June 18, 2016, 04:39:16 PM
I think it would be easier, if we write a whole program for ourselves, so we dont need to figure out, how the libraries are built up.

Since all values ar "just" HEX , it should be quite easy to transfer the HEX Codes.
IIRC, there are usable MIDI-Libraries for Languages like C/C# and so on.

^^^Seee? I knew a big brain would show up - Thanks Griphook! Welcome to the Depot, how come I haven't heard about you in the Introduce Yourself thread? Am I slacking (again)?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 19, 2016, 03:55:32 AM
Indeed, I introduced myself, but hey, Here I am  ;)

I already tried to code something, but it was not very succesful. My programming skills are not quite good enough to link all components, like Midi-Port Opening, integrate some fancy graphics and so on.
But I'd love to help working on this, since I complained about the lack of a good Patch-Editor.

I tried to analyse some of my MP-1 Patches.
The HEX-Codes are really a mess. I had to count the "start" and "end" of each patch.

Here are my 2 files. One withe the Patch-Dump received from the MP1 and the other is sorted. Maybe this will help a little :)

EDIT: @MJMP. Yes, I think the checksum changes, if you change a Parameter. Otherwise the checksum would be pretty pointless.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 19, 2016, 08:47:23 AM
The dump you made are from multiple patches correct?
So you already did a fine job and it seems to be correct if you compare it to the notes I posted.
F0      sysex identifier
0D     ADA identification code
10     Channel nr ,is this the actual midi channel which would be in your case 11?
0B     Load library command,there seem to be a few of these commands
01     Device code, in this case 01 is the MP-1,for the MB-1 it's 02,but this seems also be the case for the MP-2 and both   
        combo's.So we need to figure out the code for the MQ-1 and the classic.
After this you get the parameters. The amount of the parameters depends on the product.
MP-1 has 11 bytes for one patch.
MB-1 v1 21 bytes
MB-1 v2 45 bytes
MP-2 140 bytes
Quadtube 139 bytes
Tritube 75 137 bytes.
Then the last 2 bytes are the checksum and F7 (End of sysex)
The high amount of bytes used in the MP-2 seems to come from the (my guess) control change stuff and midi mapping?

So there's still a lot of work to be done figuring out stuff. Maybe we could ask Dave Tarnowski from ADA if he has the whole syses documentation of all the ADA devices. And else we have to figure it out our self.

Does anybody know what "humber" or "humber coding" is ?


Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 19, 2016, 10:41:04 AM
Thanks ^.^
Yeah, it seems to be correct, so it shouldnt be a problem to configure all patches with an array, so an Overdrive Setting of 0.1 would be 01 in Hex, 9.0 will be 26 Hex and so on.

But i didnt manage to figure out, how to replace patches with self-written onesy from an editor.

According to the MP-1 Manual Version 1 (which helped me a lot with this) Humber Means, "Most significant bits first" (https://en.wikipedia.org/wiki/Bit_numbering)

We should make some Test with som self written SysEx-Messages, so we can pre-check, whether they ar ok or not?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 19, 2016, 11:11:03 AM
So the channel nr is actually the midi channel?

Did you try the load program command?

F0 0D 10 09 01 pp b0 ...bn xx F7

09 is the load program command,08 seems to be the send program command (so the mp-1 sends one program)
pp=program nr
b0...bn data bytes
xx checksum

Did you figure out how they do the checksum

Saw that too about the MSB but I never heard of the term "humber"

Yes we could use bome sendsx to transmit the sysex messages
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on June 19, 2016, 12:07:30 PM
The high amount of bytes used in the MP-2 seems to come from the (my guess) control change stuff and midi mapping?

Of course. That, plus the MP-2 has a good deal more features, each requiring parameters - incl. the CC stuff, thus it all adds up..

Did you figure out how they do the checksum

I could imagine it might be a simple CRC + byte count checksum, like so often used in most IT stuff - like with the Linux 'cksum' program.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 19, 2016, 05:44:27 PM
I saw something in the old MP-1 V1 manual about 2s complement checksum.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 20, 2016, 06:29:45 AM
Also the MP2 stores the program name, I assume it's ASCII char set so one byte per character and probably has to be padded with NUL for the blanks which seems to be 00000000 = 0. so 256 characters (0 to 255, or 00 to FFhex, or 00000000 to 111111 base2).

Hers some sysex programming links:
http://www.2writers.com/eddie/tutsysex.htm
http://www.2writers.com/eddie/tutsysex.htm
http://www.kidnepro.com/blog/sysex-made-simple/
https://www.midi.org/specifications/item/table-4-universal-system-exclusive-messages
https://en.wikipedia.org/wiki/ASCII#Code_chart
https://cycling74.com/2012/02/14/working-with-hardware-livid%E2%80%99s-code-part-three/#.V2fp_KJPw0g
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 21, 2016, 07:11:26 AM
I just managed to read from my .syx-File to an array, but I dont get any clue, how the checksum is calculated.
The checksum "Does" or "Does Not" contain "Sysex, EOX and the checksum itself" ? I assume it doesn`t.

And what to do with the "Byte 1"-thingy written in the MP-1 Manual Version 1?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 21, 2016, 07:51:08 AM
Yes it's strange it seems they only do a checksum on the actual data so they ditch the MSB and only use the 7 bits that are left except if it's only one byte then they ditch the 2 MSB just to leave 6 bits??
Am I seeing this correct? It's very confusing.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 21, 2016, 02:03:14 PM
I don't know.
It seems to be, that the Bits of Byte 1 Are set. Independent from the Data?
So imo, nö further Information about calculating the checksum  :dunno:  :crazy:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 21, 2016, 03:46:47 PM
Tomorrow I'll do a backup of one preset and I'll see if I can figure out the checksum.

I wonder why they would ditch bits, it only makes it more complicated and in the end I really can't see what use it has.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 21, 2016, 10:09:37 PM
I could imagine, that you just dont need the first bit. The maximum value, you can reach is 40(Dec)--> 28(Hex), which is "0010 1000". So the first bit is not even touched. So why transfer it, when its not needed?

I will also get my MP-1 back at my place and try to figure this out ^^


EDIT: The MSB signs, whether the binary number is positive or not (0=positive, 1=negative). Maybe Set the MSB to 0 and all Numbers are positive?
Title: Re: ADA MP-1 Digital Modification
Post by: Boogie on June 21, 2016, 11:04:22 PM
Hey,
I think I figured out how to do the MP-2 program checksum. You're on the right track. Just send me a load program dump with manipulated bits or bytes to verify. If you don't screw up specific parameters it will load with the calculated checksum. There's other stuff I'm stuck with. The send program command works different and also the Firmware checksum.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 22, 2016, 12:45:18 AM
I don't own a MP-2, but can you explain, how the checksum is calculated ?

maybe we can make up a general way out of your solution.  :)
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 22, 2016, 03:35:00 AM
I tripped over something that explained Humber, but I didn't read it and now I can't seem to locate it again.

So if the MSB is the sign (which makes sense (and maybe that's what humber is about)) then wouldn't it get set for the -ve eq values or do they just represented by by a number range eg 0 through 20 and 10 = 0 (flat) >10 = -ve values and > 10 = +ve ??
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 22, 2016, 04:33:31 AM
Maybe this will help with the 2 - complement (http://pages.cpsc.ucalgary.ca/~jacob/Courses/Fall00/CPSC231/Slides/04-BitsAndArithmetic.pdf)

Reading the MP1 manual page:
So seems humber format means sending MSBs first for values that take multiple bytes so both ends know how to treat the bytes as they are received.  From my reading of it, the first byte (byte 1) is special. So in this first byte, MSB (bit 7) is sign ? here 0 which = +ve.  Bit 6 represents 0 or 7 (0 = 0), (1 = 7) with LSBs being the multiplier of bit 6 which defines how many additional bytes make up the value so for the >= 21 bit value we need 3 bytes for the value, so control byte is |0|1|0|0|0|0|1|1| so 6th bit =1 which is 7base10, bit 0 and bit 1 are 1 = 3base10, so 7 x 3 = 21 bits, or 3 bytes coming with MSBs first.
Maybe this is all humber format??
                                                                                                                                                                               bit 7  6  5  4 3  2 1 0
( if it's only one byte then they ditch the 2 MSB just to leave 6 bits??) so this is the first example in the MP1 manual |0 |0 |  |  |  |  |  |  | so +ve value, bit 6 (start at 0) is 0 which means not 7 (the only other choice) so this is a 1 byte value, no extra byte coming and value is in bits 0 to 5.

So this is a format/scheme to slice and dice a serial bit stream (which is what is going over the wires (midi cable)). The things at either end need to know how to interpet the stream (chop it up into meaningful chunks (slice and dice I call it LoL). So this scheme uses multiples of 7 to specify how many bytes following it make up the value, after which it would expect another control byte to define how many bytes make up the next value.  There are no doubt other bytes of info in the stream, like comms stuff (REC, AK whatever to make the connection work, it will have its own scheme/protocol). The part we are getting into here is the data stream portion.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 22, 2016, 05:11:18 AM
I tripped over something that explained Humber, but I didn't read it and now I can't seem to locate it again.

So if the MSB is the sign (which makes sense (and maybe that's what humber is about)) then wouldn't it get set for the -ve eq values or do they just represented by by a number range eg 0 through 20 and 10 = 0 (flat) >10 = -ve values and > 10 = +ve ??

According to the MP1-Manual, I created a bunch of tables, containing die Display-Value, MIDI-Value and corresponding HEX-Values.
See Attachment :)


Reading the MP1 manual page:
So seems humber format means sending MSBs first for values that take multiple bytes so both ends know how to treat the bytes as they are received.  From my reading of it, the first byte (byte 1) is special. So in this first byte, MSB (bit 7) is sign ? here 0 which = +ve.  Bit 6 represents 0 or 7 (0 = 0), (1 = 7) with LSBs being the multiplier of bit 6 which defines how many additional bytes make up the value so for the >= 21 bit value we need 3 bytes for the value, so control byte is |0|1|0|0|0|0|1|1| so 6th bit =1 which is 7base10, bit 0 and bit 1 are 1 = 3base10, so 7 x 3 = 21 bits, or 3 bytes coming with MSBs first.
Maybe this is all humber format??
This Does make Sense, BUT the "Control Bytes" do not appear in the SysEx Dump :dunno:
So we still don't know which data is taken to calculate the checksum :/

If I understand it correctly, the 2'complement is:
- Invert the Binary Number (0s will be 1s and otherwise around)
- Add 1

Imo, The binary Number(which will be inverted) consists of the sum of all the data (we don't know which bytes that are).
And the sum of the Checksum and "Data-Sum" will be 0 (discarding the overflow).

If so, when building the 2'complement of the Checksum, we should get our "Data-Sum", right? With this, we should be able to find out, which data is used to calculate the "Data-Sum" and Therefore the Checksum.

please correct me, if Im wrong ???
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 22, 2016, 06:16:58 AM
Hey GH, that sounds right to me re 2 comp and makes sense.  To calculate the check sum I think you just use (add) the data values, so the first 5 LSBs and ignore the rest. Then as you say flip the bits, so when checked, the checker add the data values, adds that number to your check sum and it should = 0 or is corrupt data values.
The program editor probably sets the control bit based on your input value ?? so it doesn't display it, my guess..
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 22, 2016, 08:45:48 AM
But what exactly Are the Data values? Only the Parameter Values?

EDIT: So the Control Bytes would just be an non-displayed Overhead, like a header from a TCP-Frame  :banana:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 22, 2016, 09:56:24 AM
Ok figured it out how to calculate the checksum.You need to take all the data except the F0 (BOX) ,F7 (EOX) and the checksum.
Then I used this tool to calculate the checksum   http://easyonlineconverter.com/converters/checksum_converter.html

Problem with this checksum calculator is that it's an 8 bit and ADA only uses 7 bits so if the hex value is 80 or higher you need to subtract 80 hex and that is the checksum.

So for the midi in (software) and out I'm using bome send SX https://www.bome.com/products/sendsx
And for midi in, out (hardware) I'm using a M-audio midisport 2x2 (on a win7 64b system)

Did some experimenting with it and it works like a charm on an mp-1.Now what I found out is that the memory protect on the mp-1 has to be set to "off" (store  bank+8). The midi channel has to be set at the same nr as you send out,so setting the midi channel to "ALL" doesn't work. (nothing happends).When you send the hex to the mp-1 the display will blink "loading".Now if the checksum is wrong it will also blink "loading" but it looks a bit different and no changes are made.

The hex for downloading the current preset is; midi channel 1 so you send this;

F0 0D 00 08 01 7F 6B F7

And the MP-1 will send the hex code of the current preset.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 22, 2016, 01:33:56 PM
Next is the classic,1 preset dump is 20 bytes (MP-1 is 19 bytes)

To do a preset dump you have to send this hex to the classic
F0 0D 00 0E 06 7F 60 F7 and it should return the current preset.(set midi channel to 1)
It seems that the ID nr of the classic is 06
This is what a preset dump looks like;
byte 1 ==> F0 (sysex start)
byte 2 ==> 0D (ADA ID)
byte 3 ==> midi channel
byte 4 ==> 0F send parameter command
byte 5 ==> 06 (classic ID)
byte 6 ==> 7F (all parameters)
byte 7 ==> effectloop 00=off 01 =on
byte 8 ==>Voicing
byte 9 ==>OD1
byte 10 ==>OD2
byte 11 ==>Master
byte 12 ==>Bass
byte 13 ==>Mid
byte 14 ==>Treble
byte 15 ==>Pres
byte 16 ==>Noise gate
byte 17 ==>Chorus Depth
byte 18 ==>Chorus Rate
byte 19 ==>Checksum
byte 20 ==>F7 (EOX)

I also tried the MQ-1 but I got no response from it.

Then there is the MP-2, these preset dumps are insane, it depends on the name that is entered but it's between 219 and 221 bytes long. Not easy to figure out.
Anyway to get a preset dump send this hex (midi ch 1)
F0 0D 00 08 03 7F 69 F7
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 22, 2016, 02:33:35 PM
 :bow: :whoohoo!:

MJMP, You Are defintely some Kind of god  :thumb-up:
Maybe i am able to Code the calculator and Customize it for ADAs 7Bit
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 22, 2016, 08:04:20 PM
nah, just got lucky.It would be great if you could do that !
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 23, 2016, 12:24:58 AM
Got it! My first algorithms were right... but just for a 8 bit checksum. I just didnt keep in mind, that ADA has only 7 bits :/ To get the 7bit-checksum, One needs to do a bitwise "AND"- Operation wit 0x7F. This will crop the result to 7 bits. 0xFF will be 8 bits and so on.

So in general, it should be as follows to calculate the 7bit-checksum:
- Sum up all data between F0 (BOX) and last 2 bits XX(Checksum) and 7F (EOX)
- Build the 2's complement(Checksum). Either
Code: [Select]
checksum = (~Data_sum)+1 or
Code: [Select]
checksum = -Data_sum- Crop the checksum with 0x7F:
Code: [Select]
checksum & 0x7F

What will we do next?  ;D
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 23, 2016, 03:59:33 AM
Correct an "AND 7F" will always make the 8th bit zero and leaves the rest unchanged. Very good!

So I'm going to do a write up of the parameters of the classic (midi value and hex code) and I'll try out the MB-1.So let's see how this one responds to midi.

So if we have the checksum calculation and all the parameters someone could write a pc program? Now this is not my cup of tea so any volunteers??
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 23, 2016, 05:20:24 AM
I will try it on the weekend. Unfortunately I can't implement any "custom" graphics. So there will be just Buttons and Sliders.
I think, I'll start with simple creating of .syx files for one preset at a time.
Since we got the most information about the MP-1 and i also got one to test, ill stick with this :)

But maybe there is a more experienced Programmer out here?

Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 24, 2016, 09:20:22 AM
No programmers here ????

Anyway I also figured out the MB-1 except for a few bytes. The MB-1 puts out 53 bytes for one preset. I'll do a write up in the weekend.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 24, 2016, 12:40:41 PM
Hey MJMP,

can you also figure out the min and max Hex Value of the Chorus Depth/Rate? That would be awesome :)

I think I can deliver "something" by tomorrow evening. I got the pure GUI, but I do have to code it in C#. Thats something new for me to learn, but I'm sure, I'll get this :)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 24, 2016, 01:36:22 PM
Well depth goes from 0 to 100 so that 00h to 64h
Rate from 0 to 10 in 0.1 increments so that's also 00h to 64h

I also asked out bass player to help out, so I gave him some info and he would take a look at it.

The MP-2 is going to be a lot of work to figure out.So any help is welcome here (yes you MP-2 users  :lol: )

Also the only downside is that if you send a preset back it won't store it, you still have to do that manually.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 24, 2016, 08:29:24 PM
So I assume there is a "store" command ?  I spose then you have to tell it where to store it ??
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 25, 2016, 08:06:20 AM
Well I don't know actually, I know if you send a whole midi dump it will be stored but a single preset isn't. I guess it's a bit normal because with a single preset you send it to the current preset it's on so this way you can store it to another preset nr.

I still have to figure out how a whole dump is build up. I know it's a different command byte.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 25, 2016, 09:14:13 AM
Well you seem to be getting there  :thumb-up:
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 25, 2016, 10:26:08 AM
As promised, here a liitle preview. The GUI is done. Also the correct Hex-Values are delivered.
For now it is just a single program Editor, but hey, its something :)

Now I need to code the correct Command-Byte and display the Values of the parameters above the sliders and in the Value-Display.
Anything else for the first Version?


Which Command bytes should Implement? And is the Midi-channel "1" 00Hex or 01Hex?

There are a lot of Things we need to figure out.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 25, 2016, 12:03:25 PM
So if you send this to mp-1    F0 0D 00 08 01 7F 6B F7 (BOX ,ADA ID,midi ch,return command,MP1 ID,all parameters,chsum,EOX)
Then the mp-1 will return 19 bytes

byte 1 ==> F0 (sysex start)
byte 2 ==> 0D (ADA ID)
byte 3 ==> midi channel (ch1 =00h ch16 0Fh)
byte 4 ==> 09 send parameter command
byte 5 ==> 01 (MP-1 ID)
byte 6 ==> 7F (all parameters)
byte 7 ==>OD1 (00h - 28h)
byte 8 ==>OD2 (00h - 28h)
byte 9 ==>Master (00h - 1Ch)
byte 10 ==>Bass (00h - 0Ch)
byte 11 ==>Mid (00h - 0Ch)
byte 12 ==>Treble (00h - 0Ch)
byte 13 ==>Pres (00h - 0Ch)
byte 14 ==> effectloop (00h=off 01h=on)
byte 15 ==>Chorus Depth (00h - 64h)
byte 16 ==>Chorus Rate (00h - 64h)
byte 17 ==>Voicing (00h=S.S. 01h=T.D. 02h=T.C.)
byte 18 ==>Checksum
byte 19 ==>F7 (EOX)

So byte 1 to byte 6 should be left the same,then you can alter byte 7 to byte 17, put the new checksum in byte 18 leave byte 19 like it is and if you send these back to the MP-1 it should take over the new settings.(you will see LoAdinG on the display)
Then you can alter the preset nr (if you want) and press store.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 25, 2016, 02:55:54 PM
the Editor is nearly done. Sometimes it happens, that some parameters won't get written in the File, but I don't know why.

And unfortunately my MP-1 does not react at all to incoming SysEx. Maybe this has something to do with the MIDI-Problems I got :/
So I can't really check the results instantly.


The only thing currently needed is the "Load-Program"-Command, Right? All other Commands are not completely "investigated"  :dunno:


Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 25, 2016, 05:46:21 PM
Did you check the midi channel setting on your mp-1,it won't work if it's set to "ALL".

The "09" command just like in my previous post.If you send these 19 bytes then it should work.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 25, 2016, 10:26:49 PM
Go guys,  :thumb-up: .  Hey GH, did you make sure MP1 memory protect is Off (or it won't respond), just a thought.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 26, 2016, 06:26:33 AM
Set to Channel 1 und double chekce the Memory Protect. It still does nothing. But I got MIDI-Probs with this since I got it, so unfortunately no "direct" testing for me :/

Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 26, 2016, 10:36:58 AM
I managed to get a mate's MP-1(v2.00 EPROM from my MP-1, beacuse it won't work with his v1.38?). Now it seems to work properly  :thumb-up:

How does the "Get Parameters" work? If I understand it correctly, this writes directly to a program, solving our "Store"-Problem.
| Command 07h | Found in: MP-1 Manual Version 1 Page 21 of 26
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 26, 2016, 03:08:01 PM
I think you can also write to a program nr with the "09" command.I always used F7 as program nr,going to try that out tomorrow and see if I send an actual program nr it will store it automatically.
I will also try the "07" command and what happends.

I don't know if this works on a V1 eprom but I'll check it out also.Would be strange because the sysex explanation is only found in the old V1 MP-1 manuals.

I tried all of this on a V2.01 eprom.

Strange it doesn't work on your mp-1 but it does on your mate mp-1 if you swap the eproms?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 27, 2016, 12:31:17 AM
That would be great. :thumb-up:

Next steps Ill try to code is a direct MIDI-Port Opening and Multiple-Program Support ;)

Nah, I bet it has something to do with my MIDI-problem. I already made a thread for this, but I have to send it to you for further troubleshooting. http://adadepot.com/index.php?topic=1346.0

I think, the 2 Manuals are a bit messed up? Taken from V1:
Quote
Level 1 software offers the following features: 100% compatibility with MIDI Spec 1.0. In addition, ADA has pioneered a phantom power system which sends AC power through a 7-pin MIDI cable to controllers such as ADA's MC-1 MIDI CONTROLLER.

Level 2 software offers upload and download of MP-1 parameters to computers with a MIDI interface using system exclusive messages. In addition, MP-I parameters may be accessed in real-time using SYSEX messages.
According to this, if Level = Version, all the SysEx Commands will only work for v2.xx, and thus belonging to Manual version v2?
Also the "Hidden-Commands" (Store -> Bank+Number) did not work with v1.38
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 27, 2016, 07:25:35 AM
Just did some reading and it seems that the "program number" isn't actually the preset nr in the mp-1.It' s a sort of code for different parameters.In the scan I uploaded there is a brief explanation about it,like for the MP-2 program nr 70 are the midi mapping parameters.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 27, 2016, 07:50:35 AM
Too bad!  :-\

But as you said before: If one program is not stored using the 09-Command, but the whole library will be stored. The why don`t we make up something out of the 0A-Command (request the whole library) and the 0B-Command (Library-Request-Response).
So 08 (for the currently selected program) equals 0A (the whole library) and 09 (send specific parameters to the current selected program) equals 0B (send the whole library)? Becaus in your scanned file it states as follows:
08 - Send Program Command
09 - Load Program Command
0A - Send Library Command
0B - Load Library Command

So we would alter just one program, but always send the whole library.


I think this will work. I'll try this asap  :)
Title: Re: ADA MP-1 Digital Modification
Post by: PrimalScream91 on June 27, 2016, 08:37:03 AM
I found this a few days ago, I'm really interested in how this will turn out! Keep up the great work!
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 27, 2016, 09:51:28 AM
Thank You!  :thumb-up: :)

Im pretty sure it works as I supposed, a few tests were successful :banana:
1. Request a bulk dump with Command 0A
Code: [Select]
For Midi-Channel 1: F0 0D 00 0A 01 68 F7 
2. Get the Response from the Device (0B-Command)
3. Alter some Bytes/presets
4. Re-calculate the checksum
5. Send the "new" Dump with 0B-Command back to the Device


So to Say the same procedure as with One Program (08-/09-Command)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 27, 2016, 10:01:43 AM
So there will be a pull down menu were you can choose the preset and then alter it?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 27, 2016, 10:12:20 AM
I think I can Do that.  :thumb-up:
But it will take a little while, because Im Not a really good Programmer at all, but Im an Optimist  ;D
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 27, 2016, 11:39:35 AM
That would be great !!
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 27, 2016, 11:15:20 PM
But I need to know how the other bulk dumps are build up, which Device Codes are used, and which parameters come with which hexcodes/Display values

I know: MP-1
I don't know: MP-1 Classic, MP-2 and MB-1
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 28, 2016, 04:20:32 AM
Hey guys, you are doing really well  :thumb-up: . And GH I like your optimism.  :whoohoo!:
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 28, 2016, 06:30:18 AM
So if you send this to mp-1    F0 0D 00 08 01 7F 6B F7 (BOX ,ADA ID,midi ch,return command,MP1 ID,all parameters,chsum,EOX)
Then the mp-1 will return 19 bytes

byte 1 ==> F0 (sysex start)
byte 2 ==> 0D (ADA ID)
byte 3 ==> midi channel (ch1 =00h ch16 0Fh)
byte 4 ==> 09 send parameter command
byte 5 ==> 01 (MP-1 ID)
byte 6 ==> 7F (all parameters)
byte 7 ==>OD1 (00h - 28h)
byte 8 ==>OD2 (00h - 28h)
byte 9 ==>Master (00h - 1Ch)
byte 10 ==>Bass (00h - 0Ch)
byte 11 ==>Mid (00h - 0Ch)
byte 12 ==>Treble (00h - 0Ch)
byte 13 ==>Pres (00h - 0Ch)
byte 14 ==> effectloop (00h=off 01h=on)
byte 15 ==>Chorus Depth (00h - 64h)
byte 16 ==>Chorus Rate (00h - 64h)
byte 17 ==>Voicing (00h=S.S. 01h=T.D. 02h=T.C.)
byte 18 ==>Checksum
byte 19 ==>F7 (EOX)

So byte 1 to byte 6 should be left the same,then you can alter byte 7 to byte 17, put the new checksum in byte 18 leave byte 19 like it is and if you send these back to the MP-1 it should take over the new settings.(you will see LoAdinG on the display)
Then you can alter the preset nr (if you want) and press store.


@MJMP: If you could do such a list for the remaining Devices, that would be great. :)
I assume the Library Command stays the same, despite the Device Code.

Thank you, R  :) :thumb-up:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 28, 2016, 09:16:57 AM
Next is the classic,1 preset dump is 20 bytes (MP-1 is 19 bytes)

To do a preset dump you have to send this hex to the classic
F0 0D 00 0E 06 7F 60 F7 and it should return the current preset.(set midi channel to 1)
It seems that the ID nr of the classic is 06
This is what a preset dump looks like;
byte 1 ==> F0 (sysex start)
byte 2 ==> 0D (ADA ID)
byte 3 ==> midi channel
byte 4 ==> 0F send parameter command
byte 5 ==> 06 (classic ID)
byte 6 ==> 7F (all parameters)
byte 7 ==> effectloop 00=off 01 =on
byte 8 ==>Voicing 00=SS 01=TC 02=brown 03=TD
byte 9 ==>OD1 00 to 64
byte 10 ==>OD2 00 to 64
byte 11 ==>Master 00 to 64
byte 12 ==>Bass 00 to 0C
byte 13 ==>Mid 00 to 0C
byte 14 ==>Treble 00 to 0C
byte 15 ==>Pres 00 to 0C
byte 16 ==>Noise gate 00 to 64
byte 17 ==>Chorus Depth 00 to 64
byte 18 ==>Chorus Rate 00 to 64
byte 19 ==>Checksum
byte 20 ==>F7 (EOX)

I also tried the MQ-1 but I got no response from it.

Then there is the MP-2, these preset dumps are insane, it depends on the name that is entered but it's between 219 and 221 bytes long. Not easy to figure out.
Anyway to get a preset dump send this hex (midi ch 1)
F0 0D 00 08 03 7F 69 F7

Already posted this on page 5,this is for the classic. I'm working on the MB-1 but I still need figure out some bytes.The MB-1 puts out a whooping 53 bytes (V2.05)

BTW the classic has a different program command,it's not "08" but "0E",it does return something with 08 but I don't know what.The "0E" command returns the current preset.In the upload (byte 4) you need to put "0F" and not "09"
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 28, 2016, 10:29:42 AM
Here is what I have so far of the MB-1.I'm missing 8 bytes.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 28, 2016, 01:31:17 PM
Thanks :)
I somehow overlooked it  :o

So the Classic is complete Hex, too :thumb-up: Nice :bow:
I'll get the Display Values from my own MP-1 Classic.

I don't own a MB-1 so no help from my side in this point, Sorry :|


Can you try a whole Dump(Library)? Using the 0A/0B Command, because those are the ones, which seem to be the same for all Devices(According to your scanned document). And I would like to use those Commmands.

Isn't there any possibility to get those lacking Appendixes? Does ADA maybe has some Kind of Archive? :dunno:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 28, 2016, 02:32:01 PM
I'll try it tomorrow and let you know.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 29, 2016, 04:35:50 AM
You guys are going great guns  :whoohoo!: .  MB1s have 256 internal presets and use the midi mapping feature to access them from the foot switch, or you can scroll through them from the front panel. Also parameters are a little different:
Tube input, contour (6 voices), overdrive, master | SS input, contour (5 voices), master | compressor | EQ lo, lo mid (freq), mid (freq), hi mid (freq), hi |chorus (depth, rate) | Loop |

The manual doesn't say much, seems we need the "MB-1 MIDI SOFTWARE SPECIFICATIONS AND PROGRAMMERS GUIDE", does any one have that ??
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 29, 2016, 04:57:37 AM
I think the only one that has this is Dave T from ada amps.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 29, 2016, 05:11:07 AM
Then maybe he has the other needed Documents, too?
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 29, 2016, 05:14:04 AM
In the manual it says it was available, but maybe they never released it ?
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 29, 2016, 05:15:31 AM
I sent Monty a PM a while ago to see if he could help get some doco, haven't heard back from him so far.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 29, 2016, 07:17:43 AM
Maybe we should ask Dave from ADA?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 29, 2016, 07:58:14 AM
I do not have any contact-information, but maybe you Do?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 29, 2016, 11:29:12 AM
http://www.adaamps.com/Contact.htm
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on June 29, 2016, 01:02:55 PM
I have Dave's skype, can contact him. We should've had a chat long ago anyways (about things from the past).
Drop me a PM with what info we need the most for the projects currently taking place.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 29, 2016, 01:40:54 PM
Well anything ADA midi sysex related he has about the MQ-1, MP-1, MP-1 classic, MP-2 and the 2 combo's.

I attached a pdf on page 2 of this topic but it's incomplete, so it would be great if he has everything.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on June 30, 2016, 07:04:34 AM
And the MB-1 Midi Software Specification and Programmers Guide (which the MB-1 manual says was available)  :thumb-up:   I suspect it will also help with the other models.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 30, 2016, 10:45:27 AM


Can you try a whole Dump(Library)? Using the 0A/0B Command, because those are the ones, which seem to be the same for all Devices(According to your scanned document). And I would like to use those Commmands.



I tried it with the classic BUT I have stumbled on a problem.When you put a sysex dump back it doesn't overwrite the current parameters so you have to go a preset up and back down to load them.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 30, 2016, 11:01:55 AM
Ups, sorry I didn't mention that. Had this also.

But it should work, if you send program changes after the Dump Load (0B)

So if you altered Program 128 youd send
Code: [Select]
F0...0B....F7
C0 7E
C0 7F

This will send the Dump, change the Preset to 127 and immediately to 128 back again.
The Problem with  this will probably be, that we are not able to read out, which Program is the current selected one. But does this matter?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 30, 2016, 11:33:08 AM
Mmm yes that's a good solution.But like you say how do you know what your current preset is.Else we could use both commands.So either you want to tweak the current preset and use the "08" and "09" commands or you you can alter the existing presets with the "0A" and "0B" commands?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on June 30, 2016, 01:26:36 PM
Of course we could do that, but then you would have to press the store-Button.

Another idea: The Preset, which should be reloaded can be selected, too. So one does simply set it to the one desired.  :dunno:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on June 30, 2016, 01:29:56 PM
I guess it all depends how you want to use it. I think I would use the current preset,and if you like it you just need to store it. Also this way you can never mess your presets up.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 01, 2016, 04:08:08 AM
I personally will go withe the whole dump, just because all my other devices work like this.
But, it shouldn`t be a problem to implement both Command-Sets

But I really struggle with the MIDI-I/O Implementation. I just dont have a clue, how this works.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 01, 2016, 07:49:15 AM
That's something I can't help you with,no experience at all.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 01, 2016, 08:54:55 AM
I can't help myself with this either  :blank: ;D


But I think this is a minor issue. Because saving the Data as *.syx file is possible, and importing the file with Bome SendSX is possible.
I will concentrate on the Command-Implementation and use of a whole Data Dump.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 01, 2016, 11:34:20 AM
Is it not easier just to use 1 preset dump then a whole data dump?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 01, 2016, 11:49:07 AM
If it's just that, then the Program would be ready  :wave:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 09, 2016, 07:36:20 PM
Hey GH, any updates?

I ordered some parts to make a hardware version of it.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 11, 2016, 10:00:58 AM
The Main Part for the MP1 is ready. But I don't have a freaking clue, How to Export the Code to a exe-file :-D

Im working on a better Version and smaller event-handling and also on tHe MIDI Port
But still a lomg was to go.



Currently I am in Italy, so no PC and Codes for me.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 11, 2016, 10:35:24 AM
Ok there's no rush ,enjoy the time in Italy  :thumb-up:
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 12, 2016, 12:23:09 AM
Oh ups. I wrote that with my mobile Phone.

I will send an update asap  :)
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 12, 2016, 02:59:50 AM
I need a list with differences between the Models.

Am I right, that the MP-1 is the base for every other model? Or are there functions, which are not available in other preamps?

The Classic just has an additional Noise Gate and the brown channel. Are the display values and the value ranges the same?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 12, 2016, 03:37:06 AM
I think the classic has different ranges,don't use mine much so maybe other classic users can chime in?
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on July 12, 2016, 05:39:19 AM
Hey GH, bloody freezing here in Canberra, enjoy the sun in Italy  :thumb-up: .

I think the MP1 and Classic will be very similar. Not sure what additional parameters (if any) they added for the stereo loop. Or range changes ??
The MP2 has quite a few additional parameters, 10 voices, wah, tremolo, gate, graphic EQ, stereo parallel loop (so has in/out and A and B return/mix values).
The MB1 is different again, 256 internal patches, independent (but combinable) tube (6 contours + overdrive) and SS (5 contours), and the eq section has hi and low shelf and 3 sweep mids, loop has A/B A+B selectable.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 12, 2016, 07:17:40 AM
The classic tone section ranges from -12dB to +12dB in steps of 2dB.Chorus range is the same as the mp-1.The rest I need to checkout.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 13, 2016, 11:07:09 PM
Argh...

I took a look at the Classics Preset Dump posted a few pages earlier.
Unfortunately that dump is way to different compared to a normal MP1.

So I have to code a function for each Device and each Dump.
The library Dumps seem to be different to the single-Program-Dumps, too (according to the scanned midi-sysex.pdf)

So still a long long way to go, until the Program works with all Devices  :-\
I will post a Version, if the MP-1 works
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on July 13, 2016, 11:12:45 PM
Hey GH, I feel a "case" statement or similar is imminent LoL
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 13, 2016, 11:17:33 PM
Yeah, I'm already using that,but the order of the parameters is different too, so it is a new handling for every device.
Also the Parameters Count alters :facepalm:
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on July 14, 2016, 12:12:11 AM
Hey GH, I think initially, you'd need to set up separate data structures for each model, so a Record data type consisting of the various parameter elements (integer, real, boolean).  Which is probably where your thinking is going anyway ?  Then you could look for similarities and reuse other declared data types (if they are the same structure) e.g. chorus ? which would be a Record of on/off (boolean), depth (integer) and rate (real).
So something like (its been a while since I did this stuff, need to brush up on it):
Declare
Chorus: C_Record
  C_Record:
  C_Status: Boolean
  C_Depth: Small Integer
  C_Rate: Real

With C_Record do
blah
blah
blah
end With


This chorus (Record) data structure can then probably be reused for each model (if they are the same (I think they are?)). But then the processing needs to cope with the different Record structures for each unit. So in the end it seems easier to do a module (procedure) for each preamp with the appropriate procedures and functions specific to it.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 14, 2016, 09:52:14 AM
The Declaration is not the real problem here, The different values, Dump-Structures, Parameter-Counts, ranges and so on are.

BTW, every parameter belongs to a hex value, so all parameters are (unsigned)integer, which I convert to the Bytes


I`m currently on about 640 rows of code, excluding usage of external classes, references and the GUI-Build  ::) ;D
I said, the MP1-Program would be ready, but I started from scratch due to the Device-Specific Requirements.

For now, I am able to read a whole MP-1 Data-Dump from a .syx-File and display each Program (chose each Program).
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 14, 2016, 11:10:44 AM
Nice!

So I did some testing on the classic and OD1,OD2,Master,Chorus rate and noise gate treshold all go from 0.0 to 10.0 in 0.1 steps.Chorus goes from 0 to 100 in steps of 1,tone controls go from -12dB to +12dB in 2dB steps.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 25, 2016, 03:36:31 PM
I reached the 1000 rows of code :banana-rock:

Only a little bit of Layouting and Designing and the Editor is ready to go  :)

Implemented are the MP-1 and the MP-1 Classic. Did not manage to test with the Classic, but the file structure is correct(Maybe I have to adjust the Commands)

Here is a little Sneak-Peak of the Layout.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 25, 2016, 03:55:29 PM
Looks great, I have a classic,so if you want me to test it out for you, just let me know.
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on July 26, 2016, 01:48:54 AM
I reached the 1000 rows of code :banana-rock:

So, another 9000 lines to go, and it you find only one error in those 10.000 lines, your code may be classified as man-rated - meaning that a astronaut's life may depend on it.
With all the bugs normally found in software, ADA users must require rigid programming!

Cool work, guyz!
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 26, 2016, 03:48:05 AM
As far as I tested(normally after each completed Method ::) ) I removed all Bugs and I hope there will be none, when I give it to you.

At least on the weekend I will release the first Version. Then I'm not available for a week (Wacken  :metal: )
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 29, 2016, 12:41:26 PM
Soe Here it is.. Finally! :wave: :banana:

The first (I hope so) stable version of the ADA-Editor.
Currently Implemented Devices are the MP-1 and MP-1 Classic, because those were the only Devices we managed to figure out completely. Others will definetely follow.

It is a Windows-Application
.Net Framework 4.5.2 is required
x64 or x86 should work both

So just unzip the .exe and try it out.

You will be able to save and open SysEx-Files. The saved SysEx Files can be transferred via some other MIDI-program like "Bome SendSX" or "MIDI-OX"

Tell me, what you think :thumb-up: :)
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 30, 2016, 04:01:00 AM
How do you select your midi device?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 30, 2016, 04:24:05 AM
I deactivated that, because it produces a Fatal Error on Close, which I cant fix atm...
So i just deactivated the MIDI-relevant Controls
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 30, 2016, 05:25:15 AM
Nothing seems to happen here,so normally if you change let's the od1 ,the mp-1 should react correct,or do you first have to make a setting and send it?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 30, 2016, 05:30:52 AM
You first make your setting, then save it as sysEx-File.
Send this SysEx-File with Bome SendSX or similar.

But now it seems, that the Checksum is not calculated properly, if it is higher than 80h
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on July 30, 2016, 06:06:50 AM
Hey Griphook, great work my friend  :thumb-up: , you are getting there and is very much appreciated  :wave: . Hopefully MikeB can try it out and see how it goes as he has MP1.  I'll have to wait for the MP2 and MB1 versions.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 30, 2016, 06:34:45 AM
So there's no midi connection, it just makes a sysex file correct?
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 30, 2016, 06:40:24 AM
Thank you R :)

Yeah, thats correct, MJ

The MIDI-Connection throws fatalErrors. And I did not write the classes and libraries of that MIDI-DLL, so it is very difficult for me to troubleshoot that :/

I also found the Issue with the non-correct loading. The Parameters are just set to the wrong position... I have not tried it that far  :facepalm: ::)
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 30, 2016, 09:54:08 AM
Here is another Try

I now totally disabled the MIDI-Controls(not visible anymore).

The Data should now be in the correct order and therefore working :)


Don't mind the Value written into the TextBox on the left after each open/save Process. This was just a test for the calculated checksum.

Next things will be:



Until this point, are there anything that bothers you? Have I forgotten something?
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on July 30, 2016, 11:56:14 AM
I get an exception every time I try to select any of the Devices.
Code: [Select]
Unhandled exception has occurred in you application.
...
InvalidArgument=Value of '0' is not valid for 'SelecedIndex
Parameter neme: SelectedIndex.

There's of course the usual details box with lots more info; haven't checked where this might be written to a text file on disk - if it does,
and screen shots of such aren't too helpful as the Details scroll box cannot be enlarged.

System is Windows 7 Pro, English, SP1, with all updates and .NET updated to 4.5.2.
The only thing I forgot was to reboot, hwich I only realized now that I've written all of this ;)
System or [manual off-line] install process didn't suggest reboot, but hey, it's windblows, so guess I should've done that.. :facepalm: :lol:

EDIT: After dismissing the exception, I can set any of the other parameters.
However, when saving as a SysEx, I get:
Code: [Select]
Error: Could not save to disk. Original reference not set to an instance of an object.

Aaaaannnd.. I'll now go do the reboot...

EDIT2: Rebooted, no change..
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 30, 2016, 02:03:59 PM
Will try the new version tomorrow.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 30, 2016, 03:10:48 PM
@vansinn
Strange...
Index of 0 should be the MP-1.

The second message when saving is a result of the "Not selected"  Device, because it seems to be Not selected..

Is it the only error Message You get, or is there anything more, You can give me?
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on July 31, 2016, 12:22:44 AM
Hehe, well, it's getting funneý here..
I have done nothing but have the lappie sleep overnight, and things have changed; see below.
I must conclude that even a reboot wasn't enough; upgrading .NET from 4.5 to 4.5.2 required the lappie to sleep on it ;)

Anyways, I can now select any Device with no errors.
However, only the MP-1 and Classic presents a full window of parameters; selecting the other ones results in a small'ish rectangle with no params.
Having selected either MP-1 or Classic and randomly changing MIDI channel, Program number, Loop, some randomly selected parameters.., I can save a .sysx file.
Saving .sysx on other device results in the same "Cannot save to file" as stated in previous post - but no further error messages or exceptions.
I can also [re]load the saved [MP-1 or Classic] .sysx files.

(EDITing done for adding clarity from test to test)
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 31, 2016, 01:31:14 AM
Hey van,

Glad it worked without really doing Something  ;D

When selecting an other Device than the MP-1 ot Classic,  there Are no controls created. So this error should be normal. I forgot to deactivate the other Devices too...
I don't have enough Information about the other Devices so i Didn't even Program anything for those.

@MJ, Did You manage to get the lacking Bytes of the other Devices?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 31, 2016, 02:10:36 AM
Could it be that there's still an error in the checksum calculation?

I made a few presets and some work,some don't.

So try this one

Clean tube OD1 2.8 OD2 2.8 MA 5.0 B 8 M 9 T 8 P 0 CD 22 CR 0.3 loop out.

This gives a checksum of 17 but it should actually be 0C.It seems to me checksums below 0x80 are calculated wrong? (I think)
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 31, 2016, 05:13:27 AM
When I try this settings, I'll get Checksum 73 and it works :???:
as SysEx-Data it is:
F0 0D 00 09 01 7F 13 13 12 0A 0A 0A 06 00 16 03 02 73 F7
Did you try the newer Version? Can you give me your SysEx-Data?
 
But on my MP-1 the Display Values are really different. I do not have a 8 for Bass and Treble, neither a 9 for Mids. It is the other way around, 9 for Bass/Treble and 8 for Mids.
Is now the MP-1 incorrect or the Program?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 31, 2016, 05:54:01 AM
Well at first I got this 

F0 0D 00 09 01 7F 13 13 12 0A 0A 0A 06 00 00 00 02 17 F7

Then I did turn off my pc and I'm retrying now and now it's correct

F0 0D 00 09 01 7F 13 13 12 0A 0A 0A 06 00 00 00 02 0C F7

Now I did got the values from your program but you already mentioned there was something wrong with the scaling.And the chorus was off.

Seems to work now.Don't know why??
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on July 31, 2016, 10:25:08 AM
Hey GH, how did you do the checksum? Do you add all bytes (no carry) then reverse the bits and add 1 and then AND 01111111 ? Working on a handheld device with an LCD screen and some quadrature encoders.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on July 31, 2016, 12:03:17 PM
I have no Idea, where those strange errors/behavior come from. :facepalm:

Yep, I use exactly this
Code: [Select]
(-(checksum)) & 0x7F which is the same as
Code: [Select]
(~(checksum)+1) & 0x7FBut first I just add every byte(with carry). The carry gets irrelevant, as soon as you do the AND 01111111.


Next Version is out:
- Fixed the MP-1 Display Value
- Deleted all unhandled devices (Only MP-1 and MP-1 Classic remain)
- Set Tone-Controls Default Value to 0
- The checksum is no longer written to the TextBox
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 01, 2016, 03:56:48 AM
Ok thanks!
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on August 01, 2016, 04:28:58 AM
Hey GH, I had a thought, not sure if it will add any value.  When running up a patch, pressing the up ^ and down v buttons together ie (^+v) zeros some parameters, I'll have to read about MP1 but e.g. MB1 will zero all the eq settings when ^+v pressed and you are editing any eq. And MP2 will zero parameters while you are editing them with ^+v press.  Anyway, I thought it may give you a quick method when editing on screen to zero things (if you can work out what command the ^+v is triggering (if any))  :dunno:
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on August 07, 2016, 01:08:34 PM
OT: First of all: Wacken was a blast!!! :metal:

I did not found anything like this on my MP-1, but I could just implement a button, which does this?
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on August 07, 2016, 11:14:54 PM
...MB1 will zero all the eq settings when ^+v pressed and you are editing any eq. And MP2 will zero parameters while you are editing them with ^+v press...

Well, I'll be d.....; all these years, and I didn't know this..
I've always wanted to be able to quickly have a clean slate, so I agree that a button in the editor to zero all EQ params would be nice.
For the MP-2, this button should be present separately for the 4-band and for the 9-band EQ sections.
I don't think it makes sense having a zero-button anywhere else [in any of the processors]..
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 08, 2016, 12:48:32 AM
So what was your top 3 of the bands you saw?

Well I did knew this but I seem to forgot about this,well no I know again about the zero button.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on August 08, 2016, 02:40:56 AM
The Button only should zero the EQ and Not the Gain or anything else?

It would be really nice, if someone could give me a List with Display Values and the Parameters of the MB1 auf Mp2


I think I'll go with this:
1. Arch Enemy
2. The Vintage Caravan
3. Iron Maiden / The Dead Daisies
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on August 08, 2016, 04:36:08 AM
Hey GH, I can do the list for you as I have both MB1 and MP2.  Another good use of the zero (or clear function) is in the MP2 title, it wipes the whole title for you when you want to name/re-name a patch. And also can be used to set system parameters back to factory default.
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on August 08, 2016, 05:21:21 AM
Hey GH, I added a page to the MP2 factory patches doc (attached), I'll do the MB1 later.  Although it's probably in the MB1 manual...
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on August 08, 2016, 08:36:08 AM
Thank you, but Wow, thats a huge amount of parameters and their Dependencies. This will take its time to get it running...
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 08, 2016, 12:36:30 PM
That's why an mp-2 preset dump is 140 bytes
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on August 09, 2016, 05:08:31 AM
That's why an mp-2 preset dump is 140 bytes
>:D

I didn't include the CC assignments (CC#s, Slots, parameters), as they are set up patch by patch (except for 2 global assignments) I assume they are also in the dump ?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 09, 2016, 02:03:28 PM
I guess so and I also think the name you give the preset is included in the dump.
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on August 09, 2016, 08:06:53 PM
I'm really enjoying lurking on this thread
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 10, 2016, 08:35:44 AM
Well I suggest since you and R are both MP-2 users that you guys figure those 140 bytes out, it might be a fun project to do  :lol:
Title: Re: ADA MP-1 Digital Modification
Post by: Dante on August 10, 2016, 11:11:01 AM
you guys lost me six pages ago  :facepalm:

i'll be here to make a gui when we get that far  :thumb-up:
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 10, 2016, 12:27:05 PM
I think it's almost impossible to find out what is what in 140 bytes. I think it might be best to ask Dave if he has some info about it.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on August 10, 2016, 10:57:31 PM
Any suggestions how to organize the different Parameters of the MP-2? I believe it wont fit in the small box, like the MP-1 and Classic do.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 11, 2016, 05:07:42 AM
I think we first need to figure it out, so you know what parameters are included in the dump, no?
Title: Re: ADA MP-1 Digital Modification
Post by: MikeB on August 11, 2016, 01:43:37 PM
It may be that the only approach is to do it scientifically. Start with a basic uncomplicated patch. Dump it.  Make a change to one thing.  Dump it.  Compare the two.  This will be a slow and painful process and I'm only suggesting it because I don't have an mp2 and so can't volunteer to do it myself.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 11, 2016, 02:26:35 PM
yeah maybe not a bad idea  :thumb-up:
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on August 12, 2016, 02:10:26 AM
WRT the step by step dump-testing, I'm thinking..
AFAIR, the MP-2 can be remote controlled.
If so, wouldn't it be possible to script (from a PC) this mechanism of changing one parameter, then dump, then repeat and rinse..?

Following this, there will of course be the next event: comparing all those dumps, which might be done using either a simple database or spreadsheet, methinks.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on August 12, 2016, 03:13:24 AM
The automatical change of Parameters will not work,since we do not know the exact structure of a dump.
But I think this is the only way to get the Position of the parameter in the dump, the structure of the dump and also the Hex-Range of each parameter.


I guess, we should do the same procedure with the MB-1?
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on August 12, 2016, 04:38:08 AM
I figured out most bytes in the MB-1 except for a few.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on September 03, 2016, 06:58:40 AM
That MP-2 is insane!!
Depending on the Functins turned on/off, the Preset-Dump-Size changes.. No Idea, hot wo get through this without any documentation :dunno:
Title: Re: ADA MP-1 Digital Modification
Post by: van Sinn on September 03, 2016, 10:46:45 AM
Wild shots from the hip:

Could it be that they simply use NULL terminated strings and parameters for the settings?

Lets assume Effect A has two variable parameters and one off/on switch.

With both numeric parameters defined and the switch set to On (here, defined as 01, while Off simply is left undefined and thus represented by the terminating NULL), the NULL terminated string could look like:
 56NULL23NULL01NULL
With the same two parameters defined as above, but the effect turned Off, it could look like:
 56NULL23NULLNULL
With one numeric parameter zero/neutral defined and the other value-defined, the NULL terminated string could look like:
 0NULL23NULL01NULL
With no parameters defined, the NULL terminated string could look like:
 either NULLNULLNULL or 0NULL0NULLNULL

The software would of course know how many of such effects/parameter strings to expect in total.
As such, they might not even have bothered adding some 'begin-string' identifier, nor any 'end-string' terminator, but simply le4t each sting begin after the former string's last parameter's (implicit) terminating NULL.

If it was indeed arranged like this, it can be readily observed that this would lead to a variable dump, size depending on what's defined and what's not.

Now, I'm not at all saying it's packed like this; I'm merely suggesting some odd possibilities..
How on earth, via which algorithm, the checksum is then calculated.. keine Ahnung..
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on September 03, 2016, 01:27:13 PM
Indeed, that is one possibility.

But I don't think, the algorithm for the checksum changes. A 0 or NULL does add Nothing to the actual Data-Sum; e.g.:
A0 + 12 + 0F is the same as A0 + 0 + 12 + NULL + 0F

But before getting to this, all bytes have to be figured out  O:-)

EDIT: I just needed to know that. Only on the "Hi Gain" - Voicings the OD is used, but this Parameter is also sent with the other Voicings --> The Other Voicings contain that information, even if they do not use it.
Nex thing I found out:
If the Compressors Threshold/Gain Values are over 63 (3F h), additional Bytes (41 h) are added. If the Values ar lower than 64 (40 h) , those bytes are missing. --> This is one reason, why the Dump size varies. Maybe it's the same thing with the other Parameters.


Do the Frequencies of te Graphic EQ alter, depending on the selected Voicing?

But still a long way to go..
 
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on September 03, 2016, 07:11:42 PM
Hey GH, no the graphic freq's stay the same regardless of voicing.

@MJMP, the other MB1 bytes may be for the CC# <> slot <> parameter mappings ?  These must also be part of a dump as they are patch specific, same in the MP2.
Title: Re: ADA MP-1 Digital Modification
Post by: MarshallJMP on September 05, 2016, 06:34:02 AM
No don't think so ,I got some CC and slot info in the dump.
Title: Re: ADA MP-1 Digital Modification
Post by: Griphook on September 19, 2016, 01:00:15 AM
Maybe its the same thing as the MP-2. That some Bytes are added depending on the Paramater Value

Can you guys tell me, what the "slot" and "RealTimeMidi" mean? I ahve no Idea how to interprete those things :/
Title: Re: ADA MP-1 Digital Modification
Post by: Harley Hexxe on September 19, 2016, 05:11:58 AM
The Real Time MIDI reference in the MP-2 is ADA's way of saying Continuous Control. The Slot I believe, is the program parameters you are using the CC commands within a specific program.

   That's how I interpreted that in the manual
Title: Re: ADA MP-1 Digital Modification
Post by: rnolan on September 19, 2016, 09:23:28 PM
Hey GH, have a read of the MB1 and MP2 manuals. There's an explanation I posted here http://adadepot.com/index.php?topic=1563.0 (http://adadepot.com/index.php?topic=1563.0)
Slots are a means of mapping continuous controllers to patch parameters in a 1 to many relationship (Slots are really just a data type). So a controller (identified by its assigned CC#) can be assigned to control 1 (or more) parameters of the patch. But just to spin you out, in a given patch, you can assign a CC# to more than 1 slot (and thus its associated parameters), this is how the Macros work IIRC.